Paths

Table of Contentst

Differential D13334

'
ClosedPublic
Actions

Authored by lpriestley on Jun 18 2015, 12:47 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes

Commits

Restricted Diffusion Commit
rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and…

Summary

Fixes T8565, Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '

Test Plan

Open an object with remarkup comments, add 'quote', select that text click the quote button in the remarkup menu, text should become '> quote'. Select and click again, text should become '>> quote'.

Diff Detail

Repository

rP Phabricator

Branch

remarkupquotedtext

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6833
Build 6855: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 32264.Jun 18 2015, 12:47 AM

lpriestley retitled this revision from to Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2015, 12:47 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 18 2015, 1:32 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 18 2015, 1:32 AM

Oh, do bin/celerity map too since you touched JS.

celery map

Closed by commit rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and… (authored by lpriestley, committed by lpriestley). · Explain WhyJun 18 2015, 1:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

core/

behavior-phabricator-remarkup-assist.js

20 lines

Diff 32264

View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> 'ClosedPublicActions