Page MenuHomePhabricator
Differential D13327

Use PhutilInvalidStateException
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2015, 10:26 AM.
Tags
None
Referenced Files
F13286459: D13327.diff
Tue, Jun 4, 7:16 AM
F13273403: D13327.diff
Fri, May 31, 1:53 AM
F13233346: D13327.diff
Tue, May 21, 2:13 AM
F13219357: D13327.id.diff
Sat, May 18, 5:44 PM
F13213475: D13327.diff
Fri, May 17, 7:48 AM
Unknown Object (File)
Tue, May 7, 7:13 AM
Unknown Object (File)
May 3 2024, 3:48 AM
Unknown Object (File)
Apr 25 2024, 12:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4761cb8d7390: Use PhutilInvalidStateException
Summary

Use PhutilInvalidStateException where appropriate.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6826
Build 6848: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32245.Jun 17 2015, 10:26 AM
joshuaspence retitled this revision from to Use PhutilInvalidStateException.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 10:26 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 17 2015, 12:02 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/aphront/AphrontController.php
84

Could probably just be MethodNotImplementedException, I think the specificity of this message is overkill.

This revision is now accepted and ready to land.Jun 17 2015, 12:02 PM
Closed by commit rP4761cb8d7390: Use PhutilInvalidStateException (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 17 2015, 9:10 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
aphront/
8 lines
applications/
auth/
engine/
2 lines
conpherence/
view/
2 lines
dashboard/
engine/
4 lines
infrastructure/
markup/
5 lines
view/
form/
control/
4 lines
7 lines
layout/
4 lines
2 lines
phui/
2 lines

Diff 32245

View Options

src/aphront/AphrontController.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthInviteEngine.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

src/view/layout/PhabricatorActionListView.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
Phabricator · Built by Phacility