Page MenuHomePhabricator
Differential D13327

Use PhutilInvalidStateException
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2015, 10:26 AM.
Tags
None
Referenced Files
F15453849: D13327.diff
Sat, Mar 29, 2:50 PM
F15411974: D13327.id32245.diff
Wed, Mar 19, 10:37 AM
F15384763: D13327.id32245.diff
Fri, Mar 14, 8:44 PM
F15384433: D13327.id.diff
Fri, Mar 14, 7:53 PM
F15283456: D13327.diff
Mar 4 2025, 7:25 AM
Unknown Object (File)
Feb 11 2025, 9:31 PM
Unknown Object (File)
Feb 7 2025, 6:06 PM
Unknown Object (File)
Feb 7 2025, 7:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4761cb8d7390: Use PhutilInvalidStateException
Summary

Use PhutilInvalidStateException where appropriate.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6826
Build 6848: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32245.Jun 17 2015, 10:26 AM
joshuaspence retitled this revision from to Use PhutilInvalidStateException.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 10:26 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 17 2015, 12:02 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/aphront/AphrontController.php
84

Could probably just be MethodNotImplementedException, I think the specificity of this message is overkill.

This revision is now accepted and ready to land.Jun 17 2015, 12:02 PM
Closed by commit rP4761cb8d7390: Use PhutilInvalidStateException (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 17 2015, 9:10 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
aphront/
8 lines
applications/
auth/
engine/
2 lines
conpherence/
view/
2 lines
dashboard/
engine/
4 lines
infrastructure/
markup/
5 lines
view/
form/
control/
4 lines
7 lines
layout/
4 lines
2 lines
phui/
2 lines

Diff 32245

View Options

src/aphront/AphrontController.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthInviteEngine.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

src/view/layout/PhabricatorActionListView.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
Phabricator · Built by Phacility