Page MenuHomePhabricator
Differential D13320

Dramatically limit the range of failures which can cause duplicate mail
ClosedPublic
Actions

Authored by epriestley on Jun 16 2015, 11:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:45 PM
Unknown Object (File)
Thu, Dec 12, 5:43 AM
Unknown Object (File)
Wed, Dec 11, 2:59 PM
Unknown Object (File)
Sun, Dec 8, 12:44 PM
Unknown Object (File)
Wed, Dec 4, 7:12 PM
Unknown Object (File)
Wed, Dec 4, 7:11 PM
Unknown Object (File)
Wed, Dec 4, 7:11 PM
Unknown Object (File)
Wed, Dec 4, 7:03 PM
View All Files
Subscribers
epriestley
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T8574: Users receiving many duplicate emails
Commits
Restricted Diffusion Commit
rP30c4783c426f: Dramatically limit the range of failures which can cause duplicate mail
Summary

Ref T8574. Currently, failures during mail body construction, feed publishing, or search indexing could cause us to retry the publishing task and potentially send duplicate mail.

Instead, build (but do not send) the mail first, then send all the mail at the very end.

This isn't completley perfect, but should make it enormously harder for duplicate mail to be generated.

Test Plan

Sent some mail, ran the daemons, saw it show up normally in the outbound queue.

Diff Detail

Repository
rP Phabricator
Branch
mail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6819
Build 6841: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32235.Jun 16 2015, 11:22 PM
epriestley retitled this revision from to Dramatically limit the range of failures which can cause duplicate mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8574: Users receiving many duplicate emails.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 16 2015, 11:22 PM
btrahan accepted this revision.Jun 16 2015, 11:25 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 11:25 PM
btrahan awarded a token.Jun 16 2015, 11:25 PM
Closed by commit rP30c4783c426f: Dramatically limit the range of failures which can cause duplicate mail (authored by epriestley, committed by epriestley). · Explain WhyJun 16 2015, 11:43 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8574: Users receiving many duplicate emails.Jun 17 2015, 12:03 AM
epriestley mentioned this in D13331: Probably fix notifications not being properly marked as unread.Jun 17 2015, 4:03 PM
epriestley mentioned this in rPaf8ad58e6bb1: Probably fix notifications not being properly marked as unread.Jun 17 2015, 5:43 PM

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
replyhandler/
4 lines
releeph/
editor/
12 lines
transactions/
editor/
40 lines

Diff 32235

View Options

src/applications/metamta/replyhandler/PhabricatorMailTarget.php

Loading...
View Options

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility