Page MenuHomePhabricator

Dramatically limit the range of failures which can cause duplicate mail
ClosedPublic

Authored by epriestley on Jun 16 2015, 11:22 PM.
Tags
None
Referenced Files
F15592686: D13320.diff
Sat, May 10, 6:08 AM
F15520774: D13320.id32236.diff
Sun, Apr 20, 8:14 AM
F15518009: D13320.id32235.diff
Sat, Apr 19, 10:09 AM
F15516676: D13320.id.diff
Fri, Apr 18, 8:37 PM
F15512564: D13320.diff
Thu, Apr 17, 11:33 AM
F15427168: D13320.id32235.diff
Mar 23 2025, 1:12 PM
F15402583: D13320.id.diff
Mar 17 2025, 11:05 PM
F15400638: D13320.id32235.diff
Mar 17 2025, 1:04 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

Ref T8574. Currently, failures during mail body construction, feed publishing, or search indexing could cause us to retry the publishing task and potentially send duplicate mail.

Instead, build (but do not send) the mail first, then send all the mail at the very end.

This isn't completley perfect, but should make it enormously harder for duplicate mail to be generated.

Test Plan

Sent some mail, ran the daemons, saw it show up normally in the outbound queue.

Diff Detail

Repository
rP Phabricator
Branch
mail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6819
Build 6841: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Dramatically limit the range of failures which can cause duplicate mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 11:25 PM
This revision was automatically updated to reflect the committed changes.