Paths

Table of Contentst

Differential D13304

Set icons for Diviner PHID types
ClosedPublic
Actions

Authored by joshuaspence on Jun 16 2015, 12:41 PM.

Tags

None

Referenced Files

	F14737249: D13304.diff
	Sun, Jan 19, 4:16 AM

	F14729358: D13304.id32220.diff
	Sat, Jan 18, 6:36 AM

	Unknown Object (File)
	Fri, Jan 17, 11:21 AM

	Unknown Object (File)
	Fri, Jan 3, 12:26 AM

	Unknown Object (File)
	Fri, Dec 20, 11:51 PM

	Unknown Object (File)
	Dec 19 2024, 12:52 AM

	Unknown Object (File)
	Dec 17 2024, 5:31 AM

	Unknown Object (File)
	Dec 14 2024, 10:22 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4558: Make Diviner useful for third-parties

Commits

Restricted Diffusion Commit
rP751162d363e6: Set icons for Diviner PHID types

Summary

Ref T4558. Give DivinerAtomPHIDType and DivinerBookPHIDType a font icon.

Test Plan

Saw icons in global search.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6798
Build 6820: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	307 ms	PhabricatorCelerityTestCase::testCelerityMaps
	13 ms	PhabricatorConduitTestCase::testConduitMethods
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled
	24 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
	12 ms	PhabricatorLibraryTestCase::testEverythingImplemented
		View Full Test Results (1 Failed · 6 Passed)

Event Timeline

joshuaspence updated this revision to Diff 32192.Jun 16 2015, 12:41 PM

joshuaspence retitled this revision from to Set icons for Diviner PHID types.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T4558: Make Diviner useful for third-parties.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2015, 12:41 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 16 2015, 1:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 1:53 PM

Closed by commit rP751162d363e6: Set icons for Diviner PHID types (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 16 2015, 9:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

phid/

DivinerAtomPHIDType.php

4 lines

DivinerBookPHIDType.php

4 lines

Diff 32192

src/applications/diviner/phid/DivinerAtomPHIDType.php

Loading...

src/applications/diviner/phid/DivinerBookPHIDType.php

Loading...