Page MenuHomePhabricator

Set icons for Diviner PHID types
ClosedPublic

Authored by joshuaspence on Jun 16 2015, 12:41 PM.
Tags
None
Referenced Files
F15516725: D13304.id32220.diff
Fri, Apr 18, 8:57 PM
F15509226: D13304.id32192.diff
Wed, Apr 16, 10:44 AM
F15457694: D13304.id32192.diff
Sun, Mar 30, 5:52 PM
F15438583: D13304.diff
Wed, Mar 26, 1:46 AM
F15431859: D13304.id32220.diff
Mon, Mar 24, 2:59 PM
F15430091: D13304.id32192.diff
Mon, Mar 24, 5:37 AM
F15427022: D13304.id.diff
Sun, Mar 23, 12:14 PM
F15425840: D13304.id32192.diff
Sun, Mar 23, 6:25 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4558: Make Diviner useful for third-parties
Commits
Restricted Diffusion Commit
rP751162d363e6: Set icons for Diviner PHID types
Summary

Ref T4558. Give DivinerAtomPHIDType and DivinerBookPHIDType a font icon.

Test Plan

Saw icons in global search.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 6798
Build 6820: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
307 msPhabricatorCelerityTestCase::testCelerityMaps
13 msPhabricatorConduitTestCase::testConduitMethods
0 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
24 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
12 msPhabricatorLibraryTestCase::testEverythingImplemented
View Full Test Results (1 Failed · 6 Passed)

Event Timeline

joshuaspence retitled this revision from to Set icons for Diviner PHID types.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 1:53 PM
This revision was automatically updated to reflect the committed changes.