Differential D13296

Fix another undeclared property
ClosedPublic
Actions

Authored by joshuaspence on Jun 15 2015, 10:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPf87ffc41ce69: Fix another undeclared property

Summary

I think that I've caught the bulk of these issues now.

Test Plan

Eyeball it.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6775
Build 6797: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32157.Jun 15 2015, 10:02 AM

joshuaspence retitled this revision from to Fix another undeclared property.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2015, 10:02 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

joshuaspence added inline comments.Jun 15 2015, 10:29 AM

src/applications/releeph/view/branch/ReleephBranchTemplate.php
7–10	I really derped this up in rP62648237c25e51f15b16b3506aa4dcc930d181b8.

Alternatively, I'm happy to just revert D13283 and D13280 if you'd prefer.

epriestley accepted this revision.Jun 15 2015, 12:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2015, 12:49 PM

I hit this, so I'm just going to pull it.

Closed by commit rPf87ffc41ce69: Fix another undeclared property (authored by joshuaspence, committed by epriestley). · Explain WhyJun 15 2015, 2:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

util/

DrydockBlueprintScopeGuard.php

2 lines

releeph/

view/

branch/

ReleephBranchTemplate.php

7 lines

Diff 32157

View Options

src/applications/drydock/util/DrydockBlueprintScopeGuard.php