Differential D13226

Fix "unmarked 0 inline comments as not undone" transactions
ClosedPublic
Actions

Authored by epriestley on Jun 9 2015, 8:28 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8483: Odd text in inline comment transaction

Commits

Restricted Diffusion Commit
rP9c82881cac2e: Fix "unmarked 0 inline comments as not undone" transactions

Summary

Fixes T8483. I did this incorrectly in D13159, by doing it correctly first and then editing it carelessly. For most transaction types, it didn't matter, but did for inline state.

Also, clean up any bad inline state transactions.

Test Plan

Ran migration, bad transactions vanished.
Marked some inline comments as done.

Diff Detail

Repository

rP Phabricator

Branch

inline1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6647
Build 6669: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31969.Jun 9 2015, 8:28 PM

epriestley retitled this revision from to Fix "unmarked 0 inline comments as not undone" transactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8483: Odd text in inline comment transaction.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 9 2015, 8:28 PM

btrahan accepted this revision.Jun 9 2015, 8:30 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2015, 8:30 PM

Closed by commit rP9c82881cac2e: Fix "unmarked 0 inline comments as not undone" transactions (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2015, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150609.inline.sql

4 lines

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

1 line

Diff 31969

View Options

resources/sql/autopatches/20150609.inline.sql