Page MenuHomePhabricator
Differential D13188

Remove `*TransactionType` classes
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2015, 11:53 AM.
Tags
None
Referenced Files
F14084233: D13188.diff
Sat, Nov 23, 7:21 AM
Unknown Object (File)
Tue, Nov 19, 4:41 AM
Unknown Object (File)
Fri, Nov 15, 11:03 AM
Unknown Object (File)
Wed, Nov 13, 4:44 AM
Unknown Object (File)
Sun, Nov 10, 5:14 PM
Unknown Object (File)
Thu, Nov 7, 8:47 AM
Unknown Object (File)
Tue, Nov 5, 9:33 AM
Unknown Object (File)
Sat, Nov 2, 9:09 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP5914bbd806e6: Remove `*TransactionType` classes
Summary

Remove the *TransactionType classes and define the constants in the corresponding *Transaction class instead.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6601
Build 6623: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31873.Jun 7 2015, 11:53 AM
joshuaspence retitled this revision from to Remove `*TransactionType` classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2015, 11:53 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 31874.Jun 7 2015, 11:55 AM
joshuaspence edited edge metadata.

Remove an unused class

epriestley accepted this revision.Jun 7 2015, 7:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2015, 7:08 PM
Closed by commit rP5914bbd806e6: Remove `*TransactionType` classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 8 2015, 1:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
11 lines
applications/
conpherence/
2 lines
__tests__/
4 lines
4 lines
conduit/
6 lines
constants/
controller/
6 lines
14 lines
editor/
74 lines
mail/
2 lines
storage/
47 lines
view/
12 lines
differential/
editor/
16 lines
storage/
37 lines
legalpad/
constants/
controller/
10 lines
editor/
60 lines
storage/
26 lines
macro/
constants/
controller/
4 lines
2 lines
4 lines
editor/
56 lines
storage/
61 lines
metamta/
constants/
storage/
8 lines
pholio/
constants/
controller/
2 lines
18 lines
editor/
110 lines
lipsum/
4 lines
storage/
150 lines
view/
8 lines

Diff 31874

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/ConpherenceTransactionRenderer.php

Loading...
View Options

src/applications/conpherence/__tests__/ConpherenceRoomTestCase.php

Loading...
View Options

src/applications/conpherence/__tests__/ConpherenceTestCase.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

Loading...
View Options

src/applications/conpherence/constants/ConpherenceTransactionType.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNewRoomController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/conpherence/mail/ConpherenceReplyHandler.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceTransaction.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/legalpad/constants/LegalpadConstants.php

Loading...
View Options

src/applications/legalpad/constants/LegalpadTransactionType.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadTransaction.php

Loading...
View Options

src/applications/macro/constants/PhabricatorMacroTransactionType.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroAudioController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroEditController.php

Loading...
View Options

src/applications/macro/editor/PhabricatorMacroEditor.php

Loading...
View Options

src/applications/macro/storage/PhabricatorMacroTransaction.php

Loading...
View Options

src/applications/metamta/constants/MetaMTANotificationType.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/pholio/constants/PholioConstants.php

Loading...
View Options

src/applications/pholio/constants/PholioTransactionType.php

Loading...
View Options

src/applications/pholio/controller/PholioMockCommentController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/editor/PholioMockEditor.php

Loading...
View Options

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php

Loading...
View Options

src/applications/pholio/storage/PholioTransaction.php

Loading...
View Options

src/applications/pholio/view/PholioTransactionView.php

Loading...
Phabricator · Built by Phacility