Page MenuHomePhabricator
Differential D13095

Digest resource cachekeys to maximum length
ClosedPublic
Actions

Authored by epriestley on Jun 1 2015, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:10 AM
Unknown Object (File)
Thu, May 2, 9:33 AM
Unknown Object (File)
Tue, Apr 30, 9:29 PM
Unknown Object (File)
Tue, Apr 30, 9:29 PM
Unknown Object (File)
Tue, Apr 30, 9:29 PM
Unknown Object (File)
Mon, Apr 29, 2:37 PM
Unknown Object (File)
Thu, Apr 25, 2:24 AM
Unknown Object (File)
Wed, Apr 17, 2:56 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8372: Resource cache
Commits
Restricted Diffusion Commit
rP7a9174fa21b7: Digest resource cachekeys to maximum length
Summary

Fixes T8372. We currently store the entire resource path in the cachekey; shorten it to a maximum of 64 characters.

The key size is 128 and T8372 had an example of a 112-byte key which could run over 128 with a slightly-long cache namespace.

Test Plan
  • Not 100% sure this is the issue, but it seems likely.
  • Dumped the cachekey before and after the change.
  • Saw values like celerity:/res/1432859262T/phabricator/e2460e8f/core.pkg.css-6eGjUCJORU3j now.

Diff Detail

Repository
rP Phabricator
Branch
cachekey
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6419
Build 6441: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31615.Jun 1 2015, 1:27 PM
epriestley retitled this revision from to Digest resource cachekeys to maximum length.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8372: Resource cache.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 1 2015, 1:27 PM
epriestley mentioned this in T8372: Resource cache.Jun 1 2015, 1:27 PM
chad accepted this revision.Jun 1 2015, 3:58 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jun 1 2015, 3:58 PM
Closed by commit rP7a9174fa21b7: Digest resource cachekeys to maximum length (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2015, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
celerity/
controller/
2 lines

Diff 31615

View Options

src/applications/celerity/controller/CelerityResourceController.php

Loading...
Phabricator · Built by Phacility