[Redesign] Fix 'nodata' display on search results
ClosedPublic
Actions

Authored by chad on May 31 2015, 10:08 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rPe230e0388077: [Redesign] Fix 'nodata' display on search results

Summary

Ref T8099, We can just set the no data string on the ObjectList directly.

Test Plan

Run a bum query, see better UI.

Diff Detail

Repository

rP Phabricator

Branch

search-nodata

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6392
Build 6414: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31578.May 31 2015, 10:08 PM

chad retitled this revision from to [Redesign] Fix 'nodata' display on search results.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 31 2015, 10:08 PM

epriestley accepted this revision.Jun 1 2015, 1:50 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 1 2015, 1:50 AM

Closed by commit rPe230e0388077: [Redesign] Fix 'nodata' display on search results (authored by chad, committed by chad). · Explain WhyJun 1 2015, 3:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

query/

PhabricatorSearchApplicationSearchEngine.php

11 lines

Diff 31578

View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

[Redesign] Fix 'nodata' display on search resultsClosedPublicActions