[Redesign] Fix 'nodata' display on search results
ClosedPublic
Actions

Authored by chad on May 31 2015, 10:08 PM.

Tags

None

Referenced Files

	F15558239: D13087.id31593.diff
	Tue, Apr 29, 1:46 AM

	F15551588: D13087.id.diff
	Sun, Apr 27, 5:32 PM

	F15544434: D13087.diff
	Sat, Apr 26, 4:54 AM

	F15507010: D13087.id31593.diff
	Tue, Apr 15, 3:47 PM

	F15471219: D13087.id.diff
	Sat, Apr 5, 4:09 AM

	F15471218: D13087.id31593.diff
	Sat, Apr 5, 4:09 AM

	F15455529: D13087.diff
	Mar 30 2025, 2:58 AM

	F15452295: D13087.id31578.diff
	Mar 29 2025, 3:37 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rPe230e0388077: [Redesign] Fix 'nodata' display on search results

Summary

Ref T8099, We can just set the no data string on the ObjectList directly.

Test Plan

Run a bum query, see better UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31578.May 31 2015, 10:08 PM

chad retitled this revision from to [Redesign] Fix 'nodata' display on search results.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 31 2015, 10:08 PM

epriestley accepted this revision.Jun 1 2015, 1:50 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 1 2015, 1:50 AM

Closed by commit rPe230e0388077: [Redesign] Fix 'nodata' display on search results (authored by chad, committed by chad). · Explain WhyJun 1 2015, 3:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

query/

PhabricatorSearchApplicationSearchEngine.php

11 lines

Diff 31593

View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

[Redesign] Fix 'nodata' display on search resultsClosedPublicActions