Page MenuHomePhabricator

Namespace Diviner book URLs
AbandonedPublic

Authored by joshuaspence on May 29 2015, 2:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:06 PM
Unknown Object (File)
Sun, Dec 15, 11:46 PM
Unknown Object (File)
Thu, Dec 12, 3:26 AM
Unknown Object (File)
Wed, Dec 11, 1:07 PM
Unknown Object (File)
Sat, Dec 7, 1:39 PM
Unknown Object (File)
Tue, Dec 3, 1:02 PM
Unknown Object (File)
Fri, Nov 29, 3:16 AM
Unknown Object (File)
Wed, Nov 27, 2:30 PM
Subscribers

Details

Summary

Ref T4558. This fixes an inconsistency with Diviner URLs. In DivinerBookPHIDType, handle URIs are set to /diviner/book/{$name}/, but the correct URL is actually /book/{$name}/. Instead of changing DivinerBookPHIDType, I figured that the /book/ routes should probably be nested under the /diviner/ route, as this is consistent with other application routes.

Test Plan

Regenerated documentation with diviner generate and browsed it through the web UI.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Warnings
SeverityLocationCodeMessage
WarningREADME.md:23TXT3Line Too Long
WarningREADME.md:27TXT3Line Too Long
WarningREADME.md:39TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 6355
Build 6377: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Namespace Diviner book URLs.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Found another URL to fix

epriestley edited edge metadata.

It's intentional that /book/ is at top level, similar to /tag/ (and, to a lesser degree, the monogram URLs).

This revision now requires changes to proceed.May 30 2015, 2:01 PM