Page MenuHomePhabricator

Improve behavior for detecting the failure to parse external linter output
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 9:30 AM.
Tags
None
Referenced Files
F13330616: D11321.diff
Mon, Jun 17, 4:14 AM
F13320975: D11321.diff
Fri, Jun 14, 6:13 AM
F13310032: D11321.diff
Mon, Jun 10, 10:51 AM
F13276145: D11321.diff
Fri, May 31, 5:35 AM
F13272235: D11321.id31252.diff
Thu, May 30, 10:44 AM
F13222179: D11321.diff
Sun, May 19, 3:25 AM
F13219717: D11321.id.diff
Sat, May 18, 8:15 PM
F13215511: D11321.id31252.diff
May 17 2024, 5:52 PM
Subscribers

Details

Summary

Currently, a lot of ArcanistExternalLinter subclasses have something like this:

if ($err && !$messages) {
  return false;
}

We can avoid this code duplication by moving this check to the ArcanistExternalLinter class.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6198
Build 6219: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve behavior for detecting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence retitled this revision from Improve behavior for detecting to Improve behavior for detecting the failure to parse external linter output.Jan 11 2015, 7:55 PM
joshuaspence edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2015, 2:02 PM
This revision was automatically updated to reflect the committed changes.