Page MenuHomePhabricator
Differential D12920

[Redesign] Make ObjectBox Header conditional
ClosedPublic
Actions

Authored by chad on May 19 2015, 4:10 AM.
Tags
None
Referenced Files
F13215313: D12920.id31097.diff
Fri, May 17, 4:28 PM
Unknown Object (File)
Fri, May 3, 5:55 AM
Unknown Object (File)
Fri, May 3, 1:21 AM
Unknown Object (File)
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Sun, Apr 21, 12:23 PM
Unknown Object (File)
Apr 8 2024, 10:52 PM
Unknown Object (File)
Mar 9 2024, 5:26 AM
Unknown Object (File)
Mar 5 2024, 10:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional
Summary

Ref T8099. In cases like dashboards, we don't always want a header with ObjectBox. This makes it optional.

Test Plan

Review a tab panel, see no weird lines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31081.May 19 2015, 4:10 AM
chad retitled this revision from to [Redesign] Make ObjectBox Header conditional.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 4:10 AM
epriestley accepted this revision.May 19 2015, 12:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 12:56 PM
Closed by commit rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional (authored by chad, committed by chad). · Explain WhyMay 19 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
3 lines

Diff 31097

View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
Phabricator · Built by Phacility