Page MenuHomePhabricator
Differential D12920

[Redesign] Make ObjectBox Header conditional
ClosedPublic
Actions

Authored by chad on May 19 2015, 4:10 AM.
Tags
None
Referenced Files
F15422118: D12920.id31081.diff
Sat, Mar 22, 5:41 AM
F15395322: D12920.diff
Sun, Mar 16, 5:35 AM
F15394295: D12920.id31081.diff
Sat, Mar 15, 11:46 PM
F15392493: D12920.id.diff
Sat, Mar 15, 3:32 PM
F15391256: D12920.id31097.diff
Sat, Mar 15, 9:04 AM
F15292743: D12920.id31081.diff
Mar 5 2025, 2:53 AM
Unknown Object (File)
Feb 8 2025, 4:43 AM
Unknown Object (File)
Feb 8 2025, 4:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional
Summary

Ref T8099. In cases like dashboards, we don't always want a header with ObjectBox. This makes it optional.

Test Plan

Review a tab panel, see no weird lines.

Diff Detail

Repository
rP Phabricator
Branch
obj-box-header
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6098
Build 6118: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31081.May 19 2015, 4:10 AM
chad retitled this revision from to [Redesign] Make ObjectBox Header conditional.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 4:10 AM
epriestley accepted this revision.May 19 2015, 12:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 12:56 PM
Closed by commit rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional (authored by chad, committed by chad). · Explain WhyMay 19 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
3 lines

Diff 31081

View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
Phabricator · Built by Phacility