[Redesign] Make ObjectBox Header conditional
ClosedPublic
Actions

Authored by chad on May 19 2015, 4:10 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional

Summary

Ref T8099. In cases like dashboards, we don't always want a header with ObjectBox. This makes it optional.

Test Plan

Review a tab panel, see no weird lines.

Diff Detail

Repository

rP Phabricator

Branch

obj-box-header

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6098
Build 6118: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31081.May 19 2015, 4:10 AM

chad retitled this revision from to [Redesign] Make ObjectBox Header conditional.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 4:10 AM

epriestley accepted this revision.May 19 2015, 12:56 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 12:56 PM

Closed by commit rP37cd1735d9ac: [Redesign] Make ObjectBox Header conditional (authored by chad, committed by chad). · Explain WhyMay 19 2015, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIObjectBoxView.php

3 lines

Diff 31081

View Options

src/view/phui/PHUIObjectBoxView.php

[Redesign] Make ObjectBox Header conditionalClosedPublicActions