Page MenuHomePhabricator
Differential D12921

Improve the robustness of the "alias function" linter rule
ClosedPublic
Actions

Authored by joshuaspence on May 19 2015, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 10:06 AM
Unknown Object (File)
Thu, Dec 12, 12:18 AM
Unknown Object (File)
Tue, Dec 10, 10:34 AM
Unknown Object (File)
Sat, Dec 7, 10:04 PM
Unknown Object (File)
Wed, Dec 4, 6:25 AM
Unknown Object (File)
Sat, Nov 30, 2:43 AM
Unknown Object (File)
Tue, Nov 26, 10:57 AM
Unknown Object (File)
Nov 22 2024, 6:11 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC9444072e2161: Improve the robustness of the "alias function" linter rule
Summary

Improve the ArcanistXHPASTLinter::LINT_ALIAS_FUNCTION linter rule. Currently this rule does not correctly handle alias functions which are not strictly lowercase.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6101
Build 6121: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31084.May 19 2015, 8:12 AM
joshuaspence retitled this revision from to Improve the robustness of the "alias function" linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2015, 8:12 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 19 2015, 1:34 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistXHPASTLinter.php
4120

Sort of irrelevant since these should never be utf8, but prefer phutil_utf8_strtolower() for consistency?

This revision is now accepted and ready to land.May 19 2015, 1:34 PM
joshuaspence updated this revision to Diff 31161.May 19 2015, 10:37 PM
joshuaspence edited edge metadata.

Use phutil_utf8_strtolower

Closed by commit rARC9444072e2161: Improve the robustness of the "alias function" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 10:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
2 lines
__tests__/
xhpast/
3 lines

Diff 31084

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/alias-functions.lint-test

Loading...
Phabricator · Built by Phacility