Page MenuHomePhabricator

Improve the robustness of the "alias function" linter rule
ClosedPublic

Authored by joshuaspence on May 19 2015, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 10:06 AM
Unknown Object (File)
Thu, Dec 12, 12:18 AM
Unknown Object (File)
Tue, Dec 10, 10:34 AM
Unknown Object (File)
Sat, Dec 7, 10:04 PM
Unknown Object (File)
Wed, Dec 4, 6:25 AM
Unknown Object (File)
Sat, Nov 30, 2:43 AM
Unknown Object (File)
Tue, Nov 26, 10:57 AM
Unknown Object (File)
Nov 22 2024, 6:11 AM
Subscribers

Details

Summary

Improve the ArcanistXHPASTLinter::LINT_ALIAS_FUNCTION linter rule. Currently this rule does not correctly handle alias functions which are not strictly lowercase.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6141
Build 6162: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve the robustness of the "alias function" linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistXHPASTLinter.php
4136

Sort of irrelevant since these should never be utf8, but prefer phutil_utf8_strtolower() for consistency?

This revision is now accepted and ready to land.May 19 2015, 1:34 PM
joshuaspence edited edge metadata.

Use phutil_utf8_strtolower

This revision was automatically updated to reflect the committed changes.