Changed "Active Prodcuts" to "Active Products" on Releeph Product Query dropdown.
(Incidentally, this is my first diff on Phabricator proper, so I hope I got it right. I'm used to SVN, not Git.)
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP1f54b95324eb: Fixed typo on Releeph product query dropdown. - Required Signatures
L28 Phacility Individual Contributor License Agreement
Make sure the change is there and didn't bork anything else.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Errors Severity Location Code Message Error src/applications/auth/provider/PhabricatorAuthProvider.php:18 PHL1 Unknown Symbol Error src/applications/celerity/CelerityResourceGraph.php:10 PHL1 Unknown Symbol Error src/applications/config/option/PhabricatorConfigOption.php:125 PHL1 Unknown Symbol Error src/applications/config/schema/PhabricatorConfigSchemaQuery.php:14 PHL1 Unknown Symbol Error src/applications/daemon/view/PhabricatorDaemonLogEventsView.php:30 PHL1 Unknown Symbol Error src/applications/daemon/view/PhabricatorDaemonLogListView.php:17 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialLocalCommitsView.php:22 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialRevisionListView.php:62 PHL1 Unknown Symbol Error src/applications/diffusion/query/DiffusionLintCountQuery.php:26 PHL1 Unknown Symbol Error src/applications/diffusion/query/lowlevel/DiffusionLowLevelQuery.php:20 PHL1 Unknown Symbol Error src/applications/diviner/atom/DivinerAtom.php:98 PHL1 Unknown Symbol Error src/applications/doorkeeper/view/DoorkeeperTagView.php:15 PHL1 Unknown Symbol Error src/applications/files/controller/PhabricatorFileDataController.php:230 PHL1 Unknown Symbol Error src/applications/fund/phortune/FundBackerCart.php:36 PHL1 Unknown Symbol Error src/applications/multimeter/data/MultimeterControl.php:91 PHL1 Unknown Symbol Error src/applications/paste/view/PasteEmbedView.php:31 PHL1 Unknown Symbol Error src/applications/phid/query/PhabricatorObjectQuery.php:81 PHL1 Unknown Symbol Error src/applications/pholio/view/PholioMockEmbedView.php:20 PHL1 Unknown Symbol Error src/applications/phortune/cart/PhortuneSubscriptionCart.php:37 PHL1 Unknown Symbol Error src/applications/search/controller/PhabricatorApplicationSearchController.php:58 PHL1 Unknown Symbol Error src/applications/search/engine/PhabricatorApplicationSearchEngine.php:36 PHL1 Unknown Symbol Error src/applications/slowvote/view/SlowvoteEmbedView.php:25 PHL1 Unknown Symbol Error src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php:59 PHL1 Unknown Symbol Error src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php:136 PHL1 Unknown Symbol Error src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:981 PHL1 Unknown Symbol - Unit
No Test Coverage - Build Status
Buildable 6072 Build 6092: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Follow the instructions in the lint message to clear lint. They are your fault, and the very first part of the message explains how to resolve them.
Comment Actions
Sorry, get rid of the shebang. The shebang warning is because the file is +x in your environment for some reason; it should not be. It is not +x in the repository.
Anyway, this is close enough. I'll fix it in the pull.
Comment Actions
(I'm near totally unfamiliar with Git. I always use SVN.) I ran arc land 'master' as instructed at the top, and it failed with
You can not land a branch onto itself -- you are trying to land 'master' onto 'master'. For more information on how to push changes, see 'Pushing and Closing Revisions' in 'Arcanist User Guide: arc diff' in the documentation. You may be able to 'arc amend' instead.
So, I ran arc amend, and that said
Amending commit message to reflect revision D12904: Fixed typo on Releeph product query dropdown..
...but did not apparently commit. Repeated both, same results. The Arcanist User Guide tells me nothing additional. I'm lost.
Comment Actions
You don't have commit rights to the repository. I've pulled the change, I just had a few other things come up.
Comment Actions
Ah, okay, well that explains that. I'm still getting my bearings around here, as my own workflows are muscle memory. Thank you!