Page MenuHomePhabricator

Add a linter rule to prevent the __lambda_func function from being redeclared
ClosedPublic

Authored by joshuaspence on May 15 2015, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 11:12 PM
Unknown Object (File)
Fri, Nov 22, 6:21 PM
Unknown Object (File)
Fri, Nov 22, 11:22 AM
Unknown Object (File)
Fri, Nov 22, 11:22 AM
Unknown Object (File)
Fri, Nov 22, 11:22 AM
Unknown Object (File)
Fri, Nov 22, 11:22 AM
Unknown Object (File)
Fri, Nov 22, 11:07 AM
Unknown Object (File)
Wed, Nov 20, 6:31 PM
Subscribers

Details

Summary

See http://phpsadness.com/sad/39. Declaring a function named __lambda_func prevents the create_function function from working. This is because create_function eval-declares the function __lambda_func, then modifies the symbol table so that the function is instead named "\0lambda_".(++$i), and returns that name.

NOTE: Personally, I don't think that anyone should use create_function. However, despite this, I think it is reasonable that no function is named __lambda_func in case some external library relies on create_function.
Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a linter rule to prevent the __lambda_func function from being redeclared.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.