Page MenuHomePhabricator

Add a linter rule to prevent the __lambda_func function from being redeclared
ClosedPublic

Authored by joshuaspence on May 15 2015, 11:42 PM.
Tags
None
Referenced Files
F15418906: D12870.diff
Fri, Mar 21, 2:17 AM
F15412975: D12870.id.diff
Wed, Mar 19, 4:07 PM
Unknown Object (File)
Mon, Mar 3, 7:40 PM
Unknown Object (File)
Feb 16 2025, 11:36 PM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Subscribers

Details

Summary

See http://phpsadness.com/sad/39. Declaring a function named __lambda_func prevents the create_function function from working. This is because create_function eval-declares the function __lambda_func, then modifies the symbol table so that the function is instead named "\0lambda_".(++$i), and returns that name.

NOTE: Personally, I don't think that anyone should use create_function. However, despite this, I think it is reasonable that no function is named __lambda_func in case some external library relies on create_function.
Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6051
Build 6071: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add a linter rule to prevent the __lambda_func function from being redeclared.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.