Page MenuHomePhabricator
Differential D12854

Add a linter rule to prevent exceptions from being thrown in a toString method
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 4:31 AM
Unknown Object (File)
Fri, Jan 24, 4:31 AM
Unknown Object (File)
Fri, Jan 24, 4:31 AM
Unknown Object (File)
Fri, Jan 24, 4:31 AM
Unknown Object (File)
Fri, Jan 24, 4:31 AM
Unknown Object (File)
Fri, Jan 24, 12:52 AM
Unknown Object (File)
Thu, Jan 23, 8:43 PM
Unknown Object (File)
Wed, Jan 22, 5:54 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8207: Add linter rule to prevent exceptions from being thrown in a __toString method
Commits
rARC1e3073a4f88e: Add a linter rule to prevent exceptions from being thrown in a toString method
Summary

Fixes T8207. It is not possible to throw an exception from within the __toString() method. Add a linter rule to prevent this from happening.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30924.May 15 2015, 6:19 AM
joshuaspence retitled this revision from to Add a linter rule to prevent exceptions from being thrown in a toString method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8207: Add linter rule to prevent exceptions from being thrown in a __toString method.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 6:19 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 17 2015, 1:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 1:03 PM
joshuaspence updated this revision to Diff 31001.May 17 2015, 10:22 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARC1e3073a4f88e: Add a linter rule to prevent exceptions from being thrown in a toString method (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 10:23 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D12892: Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION.May 17 2015, 11:13 PM
joshuaspence mentioned this in rARC8c6e1284cc65: Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION.May 17 2015, 11:15 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
34 lines
__tests__/
xhpast/
18 lines

Diff 31002

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/tostring-exception.lint-test

Loading...
Phabricator · Built by Phacility