Paths

Table of Contentst

Differential D12892

Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION
ClosedPublic
Actions

Authored by joshuaspence on May 17 2015, 11:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8c6e1284cc65: Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION

Summary

The ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION linter rule was introduced in D12854, but fails for the following:

Interfaces which declare the __toString() method.
Classes which mark the __toString() method as abstract.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31006.May 17 2015, 11:13 PM

joshuaspence retitled this revision from to Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 11:13 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 17 2015, 11:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 11:14 PM

Closed by commit rARC8c6e1284cc65: Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 11:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

10 lines

__tests__/

xhpast/

tostring-exception.lint-test

8 lines

Diff 31007

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/tostring-exception.lint-test

Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTIONClosedPublicActions