Loop will spin forever if repository is not pullable...
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP5f797b4d478b: Recover from repositories becoming unpullable - Required Signatures
L28 Phacility Individual Contributor License Agreement
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php | ||
|---|---|---|
| 153–154 | It seems like if we break, then upper while loop will enter foreach again and it will be a forever loop. I'm not sure if continue is right, maybe we should really (anyway it seems queue will be repopulated on next upper loop iteration): unset($queue[$id]); In our environment pull daemon occasionally goes into loop and never recovers, gdb backtrace tell that daemon is spinning in this loop trying to translate log entry... | |
Comment Actions
Guys any progress with it... It is really hitting pull workers hard which spin in loop doing nothing but spaming logs about repository not pullable anymore...
Comment Actions
Next time, please file a task describing the issue you're encountering and how to reproduce it. See:
https://secure.phabricator.com/book/phabcontrib/article/contributing_code/
https://secure.phabricator.com/book/phabcontrib/article/bug_reports/