Page MenuHomePhabricator

Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING
ClosedPublic

Authored by joshuaspence on May 15 2015, 11:52 PM.
Tags
None
Referenced Files
F15353112: D12871.diff
Mon, Mar 10, 8:04 PM
Unknown Object (File)
Feb 17 2025, 1:07 AM
Unknown Object (File)
Feb 15 2025, 6:14 PM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 6 2025, 3:53 AM
Subscribers

Details

Summary

Currently the error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING is slightly wrong, mentioning xsprintf instead of the actual sprintf-style function which was used. This diff changes the error message to be more correct.

Test Plan

Linted a file containing sprintf('%s') and saw a reasonable lint message.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6024
Build 6044: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.