Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 11:52 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe3a556af9b26: Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING

Summary

Currently the error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING is slightly wrong, mentioning xsprintf instead of the actual sprintf-style function which was used. This diff changes the error message to be more correct.

Test Plan

Linted a file containing sprintf('%s') and saw a reasonable lint message.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6024
Build 6044: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30958.May 15 2015, 11:52 PM

joshuaspence retitled this revision from to Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 11:52 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 17 2015, 12:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 12:57 PM

Closed by commit rARCe3a556af9b26: Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRING (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 9:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

2 lines

Diff 30958

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Improve error message from ArcanistXHPASTLinter::LINT_FORMATTED_STRINGClosedPublicActions