Differential D12853

Improve the "invalid parent scope" linter rule
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 5:43 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC1df248cc2d53: Improve the "invalid parent scope" linter rule

Summary

This linter rule was introduced in D12420, but fails to handle a specific edge case.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6001
Build 6021: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30923.May 15 2015, 5:43 AM

joshuaspence retitled this revision from to Improve the "invalid parent scope" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 5:43 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.May 15 2015, 6:22 AM

joshuaspence edited edge metadata.

epriestley accepted this revision.May 17 2015, 1:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 1:03 PM

Closed by commit rARC1df248cc2d53: Improve the "invalid parent scope" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 9:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

6 lines

__tests__/

xhpast/

no-parent-scope.lint-test

4 lines

Diff 30923

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/no-parent-scope.lint-test

Improve the "invalid parent scope" linter ruleClosedPublicActions