Page MenuHomePhabricator

Add a linter rule for incorrect use of parent scope
ClosedPublic

Authored by joshuaspence on Apr 15 2015, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 6:30 PM
Unknown Object (File)
Fri, Jan 31, 6:26 PM
Unknown Object (File)
Sun, Jan 26, 2:25 AM
Unknown Object (File)
Fri, Jan 24, 2:39 AM
Unknown Object (File)
Fri, Jan 24, 2:39 AM
Unknown Object (File)
Fri, Jan 24, 2:39 AM
Unknown Object (File)
Fri, Jan 24, 2:39 AM
Unknown Object (File)
Fri, Jan 24, 2:39 AM
Subscribers

Details

Summary

The following code is invalid:

final class MyClass {
  public function __construct() {
    parent::__construct(null);
  }
}

$x = new MyClass();

Running the above code will produce a fatal error:

PHP Fatal error:  Cannot access parent:: when current class scope has no parent
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable