Ref T7409. Adds ArcanistXHPASTLinter::LINT_ALIAS_FUNCTION for linting the use of alias funtions. Based on Generic_Sniffs_PHP_ForbiddenFunctionsSniff. See list of function aliases.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7409: Implement PHPCS lints
- Commits
- rARCe1a057b4d938: Add a linter rule for alias functions
Added unit tests.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5970 Build 5990: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Oh, I should've mentioned... I specifically excluded a bunch of aliases from the Ming extension because they seemed contradictory. For example, according to the documentation add() is an alias for swfmovie_add() and also swfsprite_add().