Page MenuHomePhabricator
Differential D12422

Add a linter rule for alias functions
ClosedPublic
Actions

Authored by joshuaspence on Apr 15 2015, 1:28 PM.
Tags
None
Referenced Files
F13245442: D12422.diff
Thu, May 23, 6:01 AM
F13226963: D12422.diff
Mon, May 20, 12:26 AM
F13222141: D12422.diff
Sun, May 19, 3:23 AM
F13219328: D12422.id.diff
Sat, May 18, 5:26 PM
F13204710: D12422.diff
Wed, May 15, 12:52 AM
F13187963: D12422.diff
Sat, May 11, 4:52 AM
Unknown Object (File)
Tue, May 7, 8:06 AM
Unknown Object (File)
Fri, May 3, 7:37 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCe1a057b4d938: Add a linter rule for alias functions
Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_ALIAS_FUNCTION for linting the use of alias funtions. Based on Generic_Sniffs_PHP_ForbiddenFunctionsSniff. See list of function aliases.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29830.Apr 15 2015, 1:28 PM
joshuaspence retitled this revision from to Add a linter rule for alias functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2015, 1:28 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Apr 15 2015, 1:28 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Apr 15 2015, 1:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 1:29 PM
joshuaspence updated this revision to Diff 30874.May 14 2015, 8:42 AM
joshuaspence edited edge metadata.

Comprehensive list of aliases

Closed by commit rARCe1a057b4d938: Add a linter rule for alias functions (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 10:01 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a comment.May 17 2015, 10:09 PM

Oh, I should've mentioned... I specifically excluded a bunch of aliases from the Ming extension because they seemed contradictory. For example, according to the documentation add() is an alias for swfmovie_add() and also swfsprite_add().

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
211 lines
__tests__/
xhpast/
14 lines

Diff 30995

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/alias-functions.lint-test

Loading...
Phabricator · Built by Phacility