Page MenuHomePhabricator
Differential D12828

Improve linter rule for useless overriding methods
ClosedPublic
Actions

Authored by joshuaspence on May 13 2015, 9:05 PM.
Tags
None
Referenced Files
F18240873: D12828.diff
Thu, Aug 21, 1:36 AM
F17990321: D12828.diff
Sat, Aug 2, 12:26 AM
F17887121: D12828.id.diff
Tue, Jul 29, 1:28 AM
F17847111: D12828.id30907.diff
Sun, Jul 27, 5:43 AM
Unknown Object (File)
May 11 2025, 9:42 AM
Unknown Object (File)
May 6 2025, 8:02 PM
Unknown Object (File)
Apr 28 2025, 6:38 AM
Unknown Object (File)
Apr 28 2025, 6:27 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCe1a051a033b8: Improve linter rule for useless overriding methods
Summary

Ref T7409. This linter rule was added in D12419, but fails in some specific cases. Improve the handling of n_DECLARATION_PARAMETER_LIST.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5951
Build 5971: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30843.May 13 2015, 9:05 PM
joshuaspence retitled this revision from to Improve linter rule for useless overriding methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2015, 9:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 14 2015, 1:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 1:07 PM
Closed by commit rARCe1a051a033b8: Improve linter rule for useless overriding methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 14 2015, 9:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
10 lines
__tests__/
xhpast/
5 lines

Diff 30843

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/useless-overriding-method.lint-test

Loading...
Phabricator · Built by Phacility