Page MenuHomePhabricator
Differential D12605

Add a linter rule to prevent hardcoded class names
ClosedPublic
Actions

Authored by joshuaspence on Apr 29 2015, 12:55 PM.
Tags
None
Referenced Files
F15506157: D12605.diff
Tue, Apr 15, 8:58 AM
F15503553: D12605.diff
Mon, Apr 14, 10:42 AM
F15501934: D12605.id30269.diff
Sun, Apr 13, 10:14 PM
F15458839: D12605.id30804.diff
Mon, Mar 31, 7:49 AM
F15452671: D12605.id.diff
Sat, Mar 29, 6:36 AM
F15452613: D12605.diff
Sat, Mar 29, 6:18 AM
F15449929: D12605.id30804.diff
Fri, Mar 28, 12:59 PM
F15430308: D12605.id30269.diff
Mon, Mar 24, 6:59 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC9090efcb40ed: Add a linter rule to prevent hardcoded class names
Summary

Add a linter rule to advise against the use of hardcoded class names. Hardcoded class names make the code harder to refactor and it is generally preferable to use the __CLASS__ magic constant instead.

Test Plan

This works, but needs some polish.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30269.Apr 29 2015, 12:55 PM
joshuaspence retitled this revision from to Add a linter rule to prevent hardcoded class names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2015, 12:55 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Apr 29 2015, 1:06 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 29 2015, 1:06 PM
joshuaspence added a child revision: D12804: Use `__CLASS__` instead of hardcoding class names.May 12 2015, 12:30 PM
joshuaspence updated this revision to Diff 30782.May 12 2015, 12:50 PM
joshuaspence edited edge metadata.

Use a regex for matching... this means that PhabricatorUser won't be matched in the PhabricatorUserEditor class, for example.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 12 2015, 12:50 PM
Closed by commit rARC9090efcb40ed: Add a linter rule to prevent hardcoded class names (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 12 2015, 9:18 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a child revision: D12806: Use `__CLASS__` instead of hard-coding class names.May 12 2015, 11:48 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
41 lines
__tests__/
xhpast/
29 lines

Diff 30804

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

Loading...
Phabricator · Built by Phacility