Page MenuHomePhabricator
Differential D12804

Use `__CLASS__` instead of hardcoding class names
ClosedPublic
Actions

Authored by joshuaspence on May 12 2015, 12:30 PM.
Tags
None
Referenced Files
F14756766: D12804.id30780.diff
Tue, Jan 21, 8:29 PM
Unknown Object (File)
Sat, Jan 11, 3:45 AM
Unknown Object (File)
Mon, Jan 6, 3:53 PM
Unknown Object (File)
Tue, Dec 31, 1:49 PM
Unknown Object (File)
Dec 22 2024, 8:47 PM
Unknown Object (File)
Dec 22 2024, 8:29 PM
Unknown Object (File)
Dec 1 2024, 1:43 PM
Unknown Object (File)
Nov 27 2024, 1:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU211230ced9ca: Use `__CLASS__` instead of hardcoding class names
Summary

Use __CLASS__ instead of hardcoding class names. Depends on D12605.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30780.May 12 2015, 12:30 PM
joshuaspence retitled this revision from to Use `__CLASS__` instead of hardcoding class names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D12605: Add a linter rule to prevent hardcoded class names.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:30 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a child revision: D12805: Use `__CLASS__` instead of hardcoding class names.May 12 2015, 12:35 PM
epriestley accepted this revision.May 13 2015, 2:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 13 2015, 2:53 PM
Closed by commit rPHU211230ced9ca: Use `__CLASS__` instead of hardcoding class names (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
storage/
connection/
mysql/
2 lines
2 lines
auth/
2 lines
channel/
4 lines
console/
2 lines
error/
4 lines
filesystem/
2 lines
2 lines
future/
2 lines
http/
2 lines
status/
2 lines
parser/
2 lines
serviceprofiler/
2 lines
utils/
__tests__/
2 lines

Diff 30844

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
View Options

src/auth/PhutilGitHubAuthAdapter.php

Loading...
View Options

src/channel/PhutilChannel.php

Loading...
View Options

src/console/PhutilConsoleFormatter.php

Loading...
View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/filesystem/PhutilLock.php

Loading...
View Options

src/future/Future.php

Loading...
View Options

src/future/http/HTTPFuture.php

Loading...
View Options

src/future/http/status/HTTPFutureCURLResponseStatus.php

Loading...
View Options

src/parser/PhutilParserGenerator.php

Loading...
View Options

src/serviceprofiler/PhutilServiceProfiler.php

Loading...
View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
Phabricator · Built by Phacility