Page MenuHomePhabricator
Differential D12804

Use `__CLASS__` instead of hardcoding class names
ClosedPublic
Actions

Authored by joshuaspence on May 12 2015, 12:30 PM.
Tags
None
Referenced Files
F15365778: D12804.id30844.diff
Tue, Mar 11, 2:07 PM
F15353097: D12804.diff
Mon, Mar 10, 8:00 PM
F15331861: D12804.diff
Fri, Mar 7, 2:39 PM
Unknown Object (File)
Feb 9 2025, 6:31 PM
Unknown Object (File)
Feb 8 2025, 4:29 AM
Unknown Object (File)
Feb 8 2025, 4:29 AM
Unknown Object (File)
Feb 8 2025, 4:29 AM
Unknown Object (File)
Jan 28 2025, 3:36 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU211230ced9ca: Use `__CLASS__` instead of hardcoding class names
Summary

Use __CLASS__ instead of hardcoding class names. Depends on D12605.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:143XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 5914
Build 5934: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30780.May 12 2015, 12:30 PM
joshuaspence retitled this revision from to Use `__CLASS__` instead of hardcoding class names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D12605: Add a linter rule to prevent hardcoded class names.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:30 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a child revision: D12805: Use `__CLASS__` instead of hardcoding class names.May 12 2015, 12:35 PM
epriestley accepted this revision.May 13 2015, 2:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 13 2015, 2:53 PM
Closed by commit rPHU211230ced9ca: Use `__CLASS__` instead of hardcoding class names (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
storage/
connection/
mysql/
2 lines
2 lines
writeguard/
56 lines
auth/
2 lines
channel/
9 lines
9 lines
console/
2 lines
error/
4 lines
filesystem/
8 lines
17 lines
2 lines
linesofalarge/
8 lines
future/
2 lines
http/
6 lines
3 lines
internationalization/
3 lines
parser/
2 lines
serviceprofiler/
2 lines
utils/
6 lines
__tests__/
2 lines

Diff 30780

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
View Options

src/auth/PhutilGitHubAuthAdapter.php

Loading...
View Options

src/channel/PhutilChannel.php

Loading...
View Options

src/channel/PhutilChannelChannel.php

Loading...
View Options

src/console/PhutilConsoleFormatter.php

Loading...
View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/filesystem/FileFinder.php

Loading...
View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/filesystem/PhutilLock.php

Loading...
View Options

src/filesystem/linesofalarge/LinesOfALargeExecFuture.php

Loading...
View Options

src/future/Future.php

Loading...
View Options

src/future/http/HTTPFuture.php

Loading...
View Options

src/future/http/HTTPSFuture.php

Loading...
View Options

src/internationalization/PhutilLocale.php

Loading...
View Options

src/parser/PhutilParserGenerator.php

Loading...
View Options

src/serviceprofiler/PhutilServiceProfiler.php

Loading...
View Options

src/utils/PhutilDirectedScalarGraph.php

Loading...
View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
Phabricator · Built by Phacility