Differential D12759

Hovercards - don't let them run off the right edge of the viewport anymore
ClosedPublic
Actions

Authored by btrahan on May 7 2015, 9:49 PM.

Tags

None

Referenced Files

	F13267046: D12759.id30675.diff
	Wed, May 29, 12:21 AM

	F13257605: D12759.diff
	Sun, May 26, 3:08 AM

	F13255541: D12759.id.diff
	Sat, May 25, 6:03 AM

	F13251961: D12759.diff
	Sat, May 25, 12:56 AM

	F13177812: D12759.diff
	Wed, May 8, 7:58 PM

	Unknown Object (File)
	Apr 30 2024, 5:19 PM

	Unknown Object (File)
	Apr 30 2024, 5:19 PM

	Unknown Object (File)
	Apr 30 2024, 5:19 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7524: Hovercards near screen edge should re-adjust placement

Commits

Restricted Diffusion Commit
rPf7c14736c173: Hovercards - don't let them run off the right edge of the viewport anymore

Summary

Fixes T7524.

Test Plan

made a task with a comment including another task. resized window so still desktop size and task reference on edge of window. invoked hovercard by bovering over task reference and noted the hovercard was completely visible.
opened the durable column and made a task reference. invoked hovercard by hovering over task reference and noted the hovercard was completely visible.

Diff Detail

Repository

Branch

T7524

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5841
Build 5861: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30668.May 7 2015, 9:49 PM

btrahan added a task: T7524: Hovercards near screen edge should re-adjust placement.

btrahan retitled this revision from to Hovercards - don't let them run off the right edge of the viewport anymore.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 7 2015, 9:49 PM

add , 10 to parseInt call like the other cool kids

epriestley accepted this revision.May 7 2015, 10:59 PM

epriestley edited edge metadata.

epriestley added inline comments.

webroot/rsrc/js/core/Hovercard.js
102–107	Maybe toss this.

This revision is now accepted and ready to land.May 7 2015, 10:59 PM

Closed by commit rPf7c14736c173: Hovercards - don't let them run off the right edge of the viewport anymore (authored by btrahan, committed by btrahan). · Explain WhyMay 7 2015, 11:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

20 lines

webroot/

rsrc/

js/

core/

7 lines

Diff 30668

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/Hovercard.js

Loading...