Page MenuHomePhabricator

Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field
ClosedPublic

Authored by epriestley on May 7 2015, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 1:42 PM
Unknown Object (File)
Thu, Jan 30, 4:36 AM
Unknown Object (File)
Fri, Jan 24, 9:28 PM
Unknown Object (File)
Fri, Jan 24, 4:12 AM
Unknown Object (File)
Fri, Jan 24, 4:12 AM
Unknown Object (File)
Fri, Jan 24, 4:12 AM
Unknown Object (File)
Fri, Jan 24, 4:11 AM
Unknown Object (File)
Tue, Jan 21, 9:15 AM

Details

Summary

Ref T8087. Prepares for eventually making these optional after T6030. See also T7443.

Test Plan
  • See the next change for the server-side part of this.
  • With both patches applied, rigged the server to return D123.
  • Created a revision, saw bare D123.
  • Updated it with bare D123, things worked properly.
  • Created this revision with full URIs.

Diff Detail

Repository
rARC Arcanist
Branch
barerev1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5829
Build 5849: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
cburroughs added inline comments.
src/differential/ArcanistDifferentialCommitMessage.php
127

Doesn't this message need to be updated for URIs and bare monograms?

  • Accurately explain the real set of allowed formats.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:39 PM
This revision was automatically updated to reflect the committed changes.