Page MenuHomePhabricator

Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields
ClosedPublic

Authored by epriestley on May 7 2015, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 12:11 PM
Unknown Object (File)
Sat, Mar 9, 2:56 AM
Unknown Object (File)
Sun, Mar 3, 4:06 PM
Unknown Object (File)
Sun, Mar 3, 1:34 PM
Unknown Object (File)
Feb 13 2024, 10:29 AM
Unknown Object (File)
Feb 3 2024, 3:44 AM
Unknown Object (File)
Jan 13 2024, 7:54 AM
Unknown Object (File)
Jan 5 2024, 6:14 PM
Tokens
"Orange Medal" token, awarded by cburroughs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added inline comments.
src/applications/differential/customfield/DifferentialRevisionIDField.php
50–51

@cburroughs, to get the short D123 behavior (instead of full URIs) in advance of T6030:

  • Wait for D12748 + D12749 (this change).
  • Get everyone to upgrade "arc" past D12748.
  • Make this change:
-  return PhabricatorEnv::getProductionURI('/D'.$id);
+  return 'D'.$id;
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:44 PM
This revision was automatically updated to reflect the committed changes.