Page MenuHomePhabricator
Differential D12748

Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 12:59 PM.
Tags
None
Referenced Files
F15460601: D12748.diff
Tue, Apr 1, 12:21 AM
F15441413: D12748.id.diff
Wed, Mar 26, 6:06 PM
F15439812: D12748.id30644.diff
Wed, Mar 26, 9:34 AM
F15438542: D12748.id30654.diff
Wed, Mar 26, 1:21 AM
F15434441: D12748.id30634.diff
Tue, Mar 25, 3:42 AM
F15432585: D12748.diff
Mon, Mar 24, 6:39 PM
F15432371: D12748.diff
Mon, Mar 24, 5:50 PM
F15397104: D12748.id30654.diff
Sun, Mar 16, 6:11 PM
View All Files
Subscribers
cburroughs
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8087: Let Phabricator parse either "Dxxx" (no URI) or "https://secure.phabricator.com/Dxxx" (full URI) in Differential Revisions
Commits
rARC73aca1f9f0b1: Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field
Summary

Ref T8087. Prepares for eventually making these optional after T6030. See also T7443.

Test Plan
  • See the next change for the server-side part of this.
  • With both patches applied, rigged the server to return D123.
  • Created a revision, saw bare D123.
  • Updated it with bare D123, things worked properly.
  • Created this revision with full URIs.

Diff Detail

Repository
rARC Arcanist
Branch
barerev1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5825
Build 5845: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30634.May 7 2015, 12:59 PM
epriestley retitled this revision from to Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8087: Let Phabricator parse either "Dxxx" (no URI) or "https://secure.phabricator.com/Dxxx" (full URI) in Differential Revisions.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 12:59 PM
epriestley added a child revision: D12749: Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields.May 7 2015, 1:01 PM
epriestley mentioned this in D12749: Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields.May 7 2015, 1:03 PM
cburroughs added a subscriber: cburroughs.May 7 2015, 4:23 PM
cburroughs added inline comments.
src/differential/ArcanistDifferentialCommitMessage.php
127

Doesn't this message need to be updated for URIs and bare monograms?

epriestley planned changes to this revision.May 7 2015, 4:41 PM

Ah, sure.

epriestley updated this revision to Diff 30644.May 7 2015, 5:19 PM
  • Accurately explain the real set of allowed formats.
btrahan accepted this revision.May 7 2015, 5:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:39 PM
Closed by commit rARC73aca1f9f0b1: Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 6:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
differential/
56 lines

Diff 30634

View Options

src/differential/ArcanistDifferentialCommitMessage.php

Loading...
Phabricator · Built by Phacility