Page MenuHomePhabricator

Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field
ClosedPublic

Authored by epriestley on May 7 2015, 12:59 PM.
Tags
None
Referenced Files
F15544975: D12748.diff
Sat, Apr 26, 8:12 AM
F15543611: D12748.id30654.diff
Fri, Apr 25, 11:47 PM
F15539558: D12748.id30634.diff
Fri, Apr 25, 2:28 AM
F15537786: D12748.diff
Thu, Apr 24, 3:42 PM
F15515436: D12748.id30654.diff
Fri, Apr 18, 10:25 AM
F15475230: D12748.id30634.diff
Sun, Apr 6, 5:44 PM
F15460601: D12748.diff
Tue, Apr 1, 12:21 AM
F15441413: D12748.id.diff
Mar 26 2025, 6:06 PM

Details

Summary

Ref T8087. Prepares for eventually making these optional after T6030. See also T7443.

Test Plan
  • See the next change for the server-side part of this.
  • With both patches applied, rigged the server to return D123.
  • Created a revision, saw bare D123.
  • Updated it with bare D123, things worked properly.
  • Created this revision with full URIs.

Diff Detail

Repository
rARC Arcanist
Branch
barerev1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5825
Build 5845: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
cburroughs added inline comments.
src/differential/ArcanistDifferentialCommitMessage.php
127

Doesn't this message need to be updated for URIs and bare monograms?

  • Accurately explain the real set of allowed formats.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:39 PM
This revision was automatically updated to reflect the committed changes.