Page MenuHomePhabricator
Differential D12474

Provide a getProjectRoot method for ArcanistLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 20 2015, 9:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 3:35 AM
Unknown Object (File)
Mon, Sep 2, 11:37 PM
Unknown Object (File)
Aug 19 2024, 6:38 AM
Unknown Object (File)
Aug 19 2024, 6:38 AM
Unknown Object (File)
Aug 19 2024, 6:38 AM
Unknown Object (File)
Aug 19 2024, 6:38 AM
Unknown Object (File)
Aug 19 2024, 6:37 AM
Unknown Object (File)
Aug 19 2024, 6:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC1d72cfc94421: Provide a getProjectRoot method for ArcanistLinter
Summary

Adds a getProjectRoot() method to the ArcanistLinter class, simplifying a bunch of code.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5824
Build 5844: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29932.Apr 20 2015, 9:19 AM
joshuaspence retitled this revision from to Provide a getProjectRoot method for ArcanistLinter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2015, 9:19 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 30633.May 7 2015, 12:56 PM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 31091.May 19 2015, 12:56 PM

Rebase

epriestley accepted this revision.May 19 2015, 3:13 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistLinter.php
254

state exception

This revision is now accepted and ready to land.May 19 2015, 3:13 PM
Closed by commit rARC1d72cfc94421: Provide a getProjectRoot method for ArcanistLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30633

View Options

src/lint/linter/ArcanistExternalLinter.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/lint/linter/ArcanistSpellingLinter.php

Loading...
Phabricator · Built by Phacility