Page MenuHomePhabricator

Provide a getProjectRoot method for ArcanistLinter
ClosedPublic

Authored by joshuaspence on Apr 20 2015, 9:19 AM.
Tags
None
Referenced Files
F13219415: D12474.diff
Sat, May 18, 6:08 PM
F13196975: D12474.diff
Sun, May 12, 11:43 PM
Unknown Object (File)
Fri, May 3, 7:57 AM
Unknown Object (File)
Thu, Apr 25, 1:56 AM
Unknown Object (File)
Apr 22 2024, 11:27 PM
Unknown Object (File)
Apr 11 2024, 2:24 AM
Unknown Object (File)
Apr 8 2024, 5:04 PM
Unknown Object (File)
Apr 6 2024, 11:18 PM
Subscribers

Details

Summary

Adds a getProjectRoot() method to the ArcanistLinter class, simplifying a bunch of code.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 5392
Build 5410: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
1,029 msArcanistPuppetLintLinterTestCase::testLinter
969 msArcanistCSSLintLinterTestCase::testLinter
182 msArcanistCSSLintLinterTestCase::testVersion
122 msArcanistChmodLinterTestCase::testLinter
228 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence retitled this revision from to Provide a getProjectRoot method for ArcanistLinter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistLinter.php
92

state exception

This revision is now accepted and ready to land.May 19 2015, 3:13 PM
This revision was automatically updated to reflect the committed changes.