Page MenuHomePhabricator
Differential D12746

Fix "not(project)" in Diffusion
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 6:03 PM
Unknown Object (File)
Wed, Dec 11, 6:22 AM
Unknown Object (File)
Sat, Dec 7, 4:26 PM
Unknown Object (File)
Sat, Nov 30, 3:39 AM
Unknown Object (File)
Fri, Nov 29, 11:37 AM
Unknown Object (File)
Mon, Nov 25, 2:46 AM
Unknown Object (File)
Thu, Nov 21, 2:08 PM
Unknown Object (File)
Wed, Nov 20, 9:05 PM
View All Files
Subscribers
avivey
epriestley

Details

Reviewers
btrahan
avivey
Maniphest Tasks
T8105: Diffusion search for "not in project" doesn't work
Commits
Restricted Diffusion Commit
rP1c399476798f: Fix "not(project)" in Diffusion
Summary

Fixes T8105. We weren't including the parent WHERE clause fragment correctly.

Test Plan

Used not(project) in a query.

Diff Detail

Repository
rP Phabricator
Branch
not1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5821
Build 5841: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30630.May 7 2015, 12:21 PM
epriestley retitled this revision from to Fix "not(project)" in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8105: Diffusion search for "not in project" doesn't work.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 12:21 PM
avivey accepted this revision.May 7 2015, 4:32 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

looks right...

This revision is now accepted and ready to land.May 7 2015, 4:32 PM
Closed by commit rP1c399476798f: Fix "not(project)" in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
query/
10 lines

Diff 30630

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
Phabricator · Built by Phacility