Page MenuHomePhabricator
Differential D12563

Rename protocol adapter classes
ClosedPublic
Actions

Authored by joshuaspence on Apr 27 2015, 9:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 11:01 AM
Unknown Object (File)
Sat, Dec 21, 7:48 AM
Unknown Object (File)
Sat, Dec 21, 6:27 AM
Unknown Object (File)
Fri, Dec 20, 1:59 PM
Unknown Object (File)
Sun, Dec 15, 8:07 AM
Unknown Object (File)
Thu, Dec 12, 6:45 PM
Unknown Object (File)
Wed, Dec 11, 2:10 PM
Unknown Object (File)
Tue, Dec 10, 7:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rP427cc221499d: Rename protocol adapter classes
Summary

Ref T5655. Rename protocol adapter classes to remove Base from the class name.

Test Plan

Unit tests still pass.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5817
Build 5837: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30160.Apr 27 2015, 9:20 AM
joshuaspence retitled this revision from to Rename protocol adapter classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 27 2015, 9:20 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.May 7 2015, 10:34 AM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 30626.May 7 2015, 10:38 AM

Rebase

epriestley accepted this revision.May 17 2015, 2:49 PM
epriestley edited edge metadata.

Oh, I thought this was a mess but this doesn't rename any non-abstract adapters which might actually appear in config files.

This revision is now accepted and ready to land.May 17 2015, 2:49 PM
Closed by commit rP427cc221499d: Rename protocol adapter classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30626

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorBaseProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php

Loading...
Phabricator · Built by Phacility