Page MenuHomePhabricator
Differential D12726

Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod
ClosedPublic
Actions

Authored by epriestley on May 5 2015, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 12:50 PM
Unknown Object (File)
Sat, Nov 23, 1:31 AM
Unknown Object (File)
Nov 19 2024, 1:51 PM
Unknown Object (File)
Nov 14 2024, 10:04 PM
Unknown Object (File)
Nov 11 2024, 3:33 PM
Unknown Object (File)
Nov 7 2024, 2:04 AM
Unknown Object (File)
Oct 15 2024, 2:57 AM
Unknown Object (File)
Oct 14 2024, 9:57 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP7f8ee4e32966: Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod
Summary

We were adding "+1" to PHP_INT_MAX, which could cause us to wrap and run git log -n -9223372036854775808 .... Git, unable to give us negative nine trillion zillion results, would then exit without producing results.

Test Plan

Got results out of this method.

Diff Detail

Repository
rP Phabricator
Branch
mergecommits
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php:27XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 5783
Build 5802: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30577.May 5 2015, 10:35 PM
epriestley retitled this revision from to Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2015, 10:35 PM
epriestley added inline comments.May 5 2015, 10:36 PM
src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
55

Specifically, this is where we'd run into a problem.

btrahan accepted this revision.May 5 2015, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 5 2015, 10:43 PM
Closed by commit rP7f8ee4e32966: Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2015, 10:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
3 lines

Diff 30577

View Options

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility