Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod
ClosedPublic
Actions

Authored by epriestley on May 5 2015, 10:35 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP7f8ee4e32966: Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod

Summary

We were adding "+1" to PHP_INT_MAX, which could cause us to wrap and run git log -n -9223372036854775808 .... Git, unable to give us negative nine trillion zillion results, would then exit without producing results.

Test Plan

Got results out of this method.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30577.May 5 2015, 10:35 PM

epriestley retitled this revision from to Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2015, 10:35 PM

epriestley added inline comments.May 5 2015, 10:36 PM

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
55	Specifically, this is where we'd run into a problem.

btrahan accepted this revision.May 5 2015, 10:43 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 10:43 PM

Closed by commit rP7f8ee4e32966: Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2015, 10:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionMergedCommitsQueryConduitAPIMethod.php

3 lines

Diff 30579

View Options

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php

Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethodClosedPublicActions