Paths

Table of Contentst

Differential D12723

Refactor logic for getting next/prev month and day on month and day views, respectively
ClosedPublic
Actions

Authored by lpriestley on May 5 2015, 8:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 12:03 PM

	Unknown Object (File)
	Thu, Apr 25, 7:14 AM

	Unknown Object (File)
	Sat, Apr 20, 4:25 AM

	Unknown Object (File)
	Sat, Apr 20, 4:25 AM

	Unknown Object (File)
	Sat, Apr 20, 4:25 AM

	Unknown Object (File)
	Sat, Apr 20, 4:19 AM

	Unknown Object (File)
	Sat, Apr 20, 3:40 AM

	Unknown Object (File)
	Tue, Apr 16, 11:05 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4393: Implement "Daily/Weekly" Calendar Mock

Commits

Restricted Diffusion Commit
rP7e4d5f76c046: Refactor logic for getting next/prev month and day on month and day views…

Summary

Ref T4393, Refactor logic for getting next/prev month and day on month and day views, respectively

Test Plan

Open Calendar search, search using month view, scroll next/prev months to observe correct navigation, repeat with day view.

Diff Detail

Repository

Branch

calendarsearchprevnextscrolling

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5779
Build 5798: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30570.May 5 2015, 8:08 PM

lpriestley retitled this revision from to Refactor logic for getting next/prev month and day on month and day views, respectively.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 5 2015, 8:08 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Sorry, I reviewed this in the reverse order so my comments are backward

just pretend you are australian

src/view/phui/calendar/PHUICalendarDayView.php
281–287	And same here?
297–304	This is just `$this->getDateTime()`, right?
305	Maybe call this $next?
313–323	Also no more callsites?
324–333	No more callsites, I think?
src/view/phui/calendar/PHUICalendarMonthView.php
252	For that matter, can we simplify this class by adding a getDateTime()?

More refactoring

epriestley accepted this revision.May 5 2015, 8:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 8:41 PM

Closed by commit rP7e4d5f76c046: Refactor logic for getting next/prev month and day on month and day views… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 5 2015, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

calendar/

PHUICalendarDayView.php

48 lines

PHUICalendarMonthView.php

34 lines

Diff 30570

src/view/phui/calendar/PHUICalendarDayView.php

Loading...

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...