Ref T4393, Refactor logic for getting next/prev month and day on month and day views, respectively
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4393: Implement "Daily/Weekly" Calendar Mock
- Commits
- Restricted Diffusion Commit
rP7e4d5f76c046: Refactor logic for getting next/prev month and day on month and day views…
Open Calendar search, search using month view, scroll next/prev months to observe correct navigation, repeat with day view.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarsearchprevnextscrolling
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5779 Build 5798: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Sorry, I reviewed this in the reverse order so my comments are backward
just pretend you are australian
| src/view/phui/calendar/PHUICalendarDayView.php | ||
|---|---|---|
| 281–287 | And same here? | |
| 297–304 | This is just $this->getDateTime(), right? | |
| 305 | Maybe call this $next? | |
| 313–323 | Also no more callsites? | |
| 324–333 | No more callsites, I think? | |
| src/view/phui/calendar/PHUICalendarMonthView.php | ||
| 252 | For that matter, can we simplify this class by adding a getDateTime()? | |