Page MenuHomePhabricator
Differential D12680

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:15 PM.
Tags
None
Referenced Files
F15527453: D12680.id30538.diff
Tue, Apr 22, 3:48 AM
F15518054: D12680.id.diff
Sat, Apr 19, 10:34 AM
F15518002: D12680.id30445.diff
Sat, Apr 19, 10:00 AM
F15514856: D12680.diff
Fri, Apr 18, 5:57 AM
F15501130: D12680.diff
Sun, Apr 13, 8:50 PM
F15495103: D12680.id30445.diff
Sun, Apr 13, 2:44 AM
F15464387: D12680.diff
Wed, Apr 2, 9:06 AM
F15458312: D12680.diff
Sun, Mar 30, 11:01 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP70c864914210: Use phutil_json_decode instead of json_decode
Summary

Generally, phutil_json_decode should be preferred over json_decode.

Test Plan

Eyellballed.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5747
Build 5766: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30445.May 3 2015, 9:15 PM
joshuaspence retitled this revision from to Use phutil_json_decode instead of json_decode.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:15 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 3 2015, 9:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2015, 9:21 PM
joshuaspence updated this revision to Diff 30510.May 4 2015, 9:11 PM
joshuaspence edited edge metadata.

Found some more

Closed by commit rP70c864914210: Use phutil_json_decode instead of json_decode (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 11:07 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D12714: Fix a lisk issue.May 5 2015, 12:02 PM
joshuaspence mentioned this in rP8d128646b31a: Fix a lisk issue.May 5 2015, 12:11 PM
epriestley mentioned this in rP31a89bb94d2a: Revert a json_decode() which decodes possible scalars.May 5 2015, 6:08 PM
epriestley mentioned this in rP5f7ee505b6b7: Revert a third json_decode() which decodes possible scalars.May 5 2015, 8:03 PM
epriestley mentioned this in rP336ccfeea12e: Revert a fourth json_decode() which decodes possible scalars.May 5 2015, 8:13 PM

Revision Contents
Changeset List

PathSize
scripts/
celerity/
2 lines
src/
applications/
conduit/
controller/
15 lines
ssh/
10 lines
console/
controller/
6 lines
differential/
__tests__/
9 lines
conduit/
2 lines
diffusion/
8 lines
controller/
5 lines
ssh/
__tests__/
2 lines
doorkeeper/
controller/
5 lines
help/
controller/
5 lines
herald/
adapter/
16 lines
controller/
10 lines
maniphest/
controller/
2 lines
2 lines
metamta/
adapter/
10 lines
contentsource/
2 lines
phame/
skins/
13 lines
phlux/
controller/
2 lines
phortune/
controller/
27 lines
policy/
controller/
9 lines
releeph/
differential/
2 lines
search/
engine/
11 lines
xhprof/
controller/
9 lines
infrastructure/
customfield/
config/
2 lines
standard/
2 lines
daemon/
bot/
9 lines
adapter/
2 lines
workers/
query/
2 lines
edges/
query/
2 lines
env/
7 lines
storage/
lisk/
2 lines
view/
phui/
2 lines

Diff 30510

View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
View Options

src/applications/conduit/ssh/ConduitSSHWorkflow.php

Loading...
View Options

src/applications/console/controller/DarkConsoleDataController.php

Loading...
View Options

src/applications/differential/__tests__/DifferentialParseRenderTestCase.php

Loading...
View Options

src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...
View Options

src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php

Loading...
View Options

src/applications/doorkeeper/controller/DoorkeeperTagsController.php

Loading...
View Options

src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Loading...
View Options

src/applications/metamta/contentsource/PhabricatorContentSource.php

Loading...
View Options

src/applications/phame/skins/PhameSkinSpecification.php

Loading...
View Options

src/applications/phlux/controller/PhluxEditController.php

Loading...
View Options

src/applications/phortune/controller/PhortunePaymentMethodCreateController.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyEditController.php

Loading...
View Options

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

Loading...
View Options

src/applications/search/engine/PhabricatorElasticSearchEngine.php

Loading...
View Options

src/applications/xhprof/controller/PhabricatorXHProfProfileController.php

Loading...
View Options

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/daemon/bot/PhabricatorBot.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php

Loading...
View Options

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

Loading...
View Options

src/infrastructure/env/PhabricatorConfigLocalSource.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
Phabricator · Built by Phacility