Page MenuHomePhabricator

Add a preference to disable ghost comments
ClosedPublic

Authored by epriestley on May 4 2015, 6:55 PM.
Tags
None
Referenced Files
F19101207: D12704.id.diff
Dec 5 2025, 2:00 AM
F19098779: D12704.diff
Dec 4 2025, 6:04 PM
F18833241: D12704.id.diff
Oct 26 2025, 2:00 AM
F18831984: D12704.diff
Oct 25 2025, 5:50 PM
F18791089: D12704.id30504.diff
Oct 16 2025, 1:43 AM
F18768292: D12704.id30502.diff
Oct 8 2025, 2:48 AM
F18618468: D12704.diff
Sep 15 2025, 12:12 AM
F18497529: D12704.diff
Sep 4 2025, 6:05 PM

Details

Summary

Ref T7447. At least some users dislike this feature so strongly that they'd prefer not to have it at all.

Test Plan

Viewed ghosts; toggled preference, no more ghosts.

Diff Detail

Repository
rP Phabricator
Branch
ghost2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5744
Build 5763: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add a preference to disable ghost comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

We could add an "Only if not Done" option easily, but bringing "Done" comments forward is so valuable for me that it's hard for me to imagine that this is really a useful setting.

I could perhaps imagine an "On revisions I am the author of, only if not Done" setting, but this seems too complicated and confusing.

chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.